Pass fd implicitly to System::FileDescriptor and System::Socket
#16137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On UNIX also delegates the implementation from `System::Socket` to `System::FileDescriptor` since it's identical.
Instead use class methods on System::Socket on Win32 for the one case where we need to configure the socket handle after accept.
ysbaddaden
commented
Sep 5, 2025
ysbaddaden
commented
Sep 5, 2025
| Crystal::System::Socket.fcntl(fd, cmd, arg) | ||
| end | ||
|
|
||
| def fcntl(cmd, arg = 0) |
There was a problem hiding this comment.
The Socket#fcntl and Socket.fcntl methods aren't portable, rely on LibC constants to call. We might want to consider deprecating 'em?
There was a problem hiding this comment.
Let's consider that in a follow up PR then.
straight-shoota
approved these changes
Sep 5, 2025
Sija
reviewed
Sep 6, 2025
|
I'm missing a change to |
mverzilli
approved these changes
Sep 8, 2025
ysbaddaden
deleted the
fix/filedescriptor-and-socket-system-integration
branch
straight-shoota
pushed a commit
that referenced
this pull request
Oct 8, 2025
…6137] (#16183) I missed a couple cases in #16137 in preparation of #16127 where we need a system indirection around the `fd`, so #16128 will be able to count a reference: - `Crystal::System::File#system_chown` - `Crystal::System::Socket#system_accept` Note that by itself the change has no impact or interest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts the refactors out of #16128.
The main point is to not pass
fdexplicitly as an argument and to instead letSystem::FileDescriptorandSystem::Socketuse thefdproperty. This allows #16128 to wrap calls affecting thefdto wrap them in a reference counter.See each individual commit for details on each change.